Update: [AEA-6218] - Update document upload Slack notification content#502
Merged
bencegadanyi1-nhs merged 7 commits intomainfrom Apr 7, 2026
Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6218 |
bencegadanyi1-nhs
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the Slack “knowledge base syncing” notification flow in syncKnowledgeBaseFunction, shifting from count-based summaries to listing document names, and adjusts dependencies/infrastructure settings to support the change.
Changes:
- Update Slack message copy/plan block titles and emit document filenames into Slack task updates.
- Add
botocore[crt]to the preprocessing Poetry dependency group (and refreshpoetry.lock). - Temporarily force-enable
SLACK_BOT_ACTIVEin CDK for PR testing.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Adds botocore with crt extra to preprocessing dependencies. |
poetry.lock |
Locks new awscrt dependency and updates lock hash accordingly. |
packages/syncKnowledgeBaseFunction/app/handler.py |
Changes Slack notification copy; extracts and posts document names during S3 event processing. |
packages/syncKnowledgeBaseFunction/tests/test_app.py |
Updates assertions to validate document names appear in Slack blocks instead of count strings. |
packages/cdk/resources/Functions.ts |
Hard-codes SLACK_BOT_ACTIVE to "true" with a TODO to revert. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bencegadanyi1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
bencegadanyi1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
bencegadanyi1-nhs
had a problem deploying
to
dev-pr
GitHub Actions
Failure
| "SLACK_BOT_TOKEN_PARAMETER": props.slackBotTokenParameter.parameterName, | ||
| "SLACK_BOT_ACTIVE": `${!props.isPullRequest}`, | ||
| // TODO: Revert to `${!props.isPullRequest}` before merging - temporarily enabled for PR testing | ||
| "SLACK_BOT_ACTIVE": "true", |
Contributor
There was a problem hiding this comment.
I think this still needs reverting (TODO)
|
kieran-wilkinson-4
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
tightens up the Slack sync message so it’s clearer what’s actually happening (per D298)